feat(about): add the About page #164
Merged
+295
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the site and the sport for people who do not know gymnastics, link the official Code of Points PDF, say that the content is not ours, and explain that the site is made for trainers and why it has a login. Plain text with links, in light and dark mode. - add a glossary: apparatus, routine, element with the A-J values, vault, D-score, E-score, final score and Code of Points - say what the calculator does not support yet: composition requirements, connection values, bonuses and the E-score - add component tests for the PDF link, the rights text, the heading order and that the page has no buttons - add the About page to docs/AI_USAGE.md Closes #146
added 2 commits
November 6, 2026 14:34
Keep the tests of the structure, the login text, the limits of the calculator and the links. The tests of the mission, the glossary and the PDF and rights text only checked that words were present, so they broke on any rewording.
Replace the line that said nothing was committed or posted with what the team changed after the first version: the trainers and the login, the A-J mapping, routines and vaults, and what the calculator does not support yet.
|
Nice, clear page, and the facts hold up: I checked them against our data (the digit after the dot is the difficulty for all 749 elements, and vault goes from 1.6 to 6.4). tsc, lint, Prettier, the build and all 321 frontend tests pass, and it reads well in dark mode. One thing: the "Element" text uses the word "grade" ("The grade is a letter…", "The code tells the grade"), which is not used anywhere else on the webpage. Could it say "difficulty" instead, like the rest of the webpage? Generated with Claude Code, from my review. |
added 2 commits
November 10, 2026 14:14
The rest of the site calls the letter of an element its difficulty. Refs: #146
# Conflicts: # docs/AI_USAGE.md # src/styles/global.css
xeniag
approved these changes
Nov 10, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the About page
Closes #146
The About page was a placeholder. It now introduces the site, explains the sport for people who do not know gymnastics, and says where the data comes from.
What the page says
Choices
src/lib/codeOfPoints.tsholds the two links, so they are in one place.global.css:.about-pageis added to the two heading rules that the Elements and gymnasts pages use, so the headings look the same.Testing
src/tests/pages/AboutPage.test.tsx): title, one h1 and h2 for each part, sections named by their headings, the PDF link, the rights text, the trainers and login text, links, and that there are no buttons.tsc -b, ESLint and all 328 frontend tests pass.Not in this PR
global.csscan conflict a little with PR feat(gymnasts): add the gymnast page #163, which edits the same heading rules. Keep both sides.🤖 Generated with Claude Code